Fix subscribe integration tests #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adibrastegarnia
added
the
do not merge ⚠️
adibrastegarnia
added
enhancement
adibrastegarnia
force-pushed
the
fix_subscribe_once
branch
2 times, most recently
from
45928db
to
fea69d0
Compare
adibrastegarnia
force-pushed
the
fix_subscribe_once
branch
from
fea69d0
to
1cfa682
Compare
adibrastegarnia
removed
the
do not merge ⚠️
ray-milkey
approved these changes
Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes and improves subscribe tests to address #237. The tests were trying to test device simulator instead of onos-config NB API. I would suggest to have custom proto handlers for each test case (instead of a having a generic one) whenever is needed instead of using a channel to return the response and handle it in a separate function.