Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON Handling: decode LeafLists given in JSON values #1200

Merged
merged 4 commits into from
Sep 8, 2020
Merged

JSON Handling: decode LeafLists given in JSON values #1200

merged 4 commits into from
Sep 8, 2020

Conversation

SeanCondon
Copy link
Contributor

Leaf lists were not tested before - now they are handled and tested in TestDevice-2.0.0 model

@SeanCondon SeanCondon added the bug 🪲 Something isn't working label Sep 7, 2020
@SeanCondon SeanCondon added this to the Aether 2020Q3 milestone Sep 7, 2020
@SeanCondon SeanCondon self-assigned this Sep 7, 2020
@adibrastegarnia
Copy link
Contributor

@SeanCondon
Makes sense. Please run the integration tests locally to make sure they all pass now.

@SeanCondon
Copy link
Contributor Author

@adibrastegarnia I was able to run the integration test today (PTO) - will try again tomorrow.

@SeanCondon SeanCondon merged commit 18e775f into onosproject:master Sep 8, 2020
@SeanCondon SeanCondon deleted the scHandleJsonLeafList branch September 8, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adibrastegarnia adibrastegarnia adibrastegarnia approved these changes

@kuujo kuujo Awaiting requested review from kuujo

@ray-milkey ray-milkey Awaiting requested review from ray-milkey

Assignees

@SeanCondon SeanCondon

Labels
bug 🪲 Something isn't working
Milestone
Aether 2020Q3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SeanCondon @adibrastegarnia