Remove initial set in synchronizer #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adibrastegarnia
added
the
do not merge ⚠️
adibrastegarnia
changed the title
adibrastegarnia
added
bug 🪲
kuujo
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1013
We should not make any changes in the configuration of a device outside controllers (i.e. using a direct Set call in synchronizer). Controllers are responsible to reconcile the existing changes in the system when a device shows up. If we want to reduce number of Set requests that should be sent down to the device, we can optimize it when we send a NB request to create a big change. I think we can safely remove this part of the code.