Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating away from onos-topo/api/device API to onos-api/go/onos/topo API #1240

Closed
wants to merge 13 commits into from

Conversation

tomikazi
Copy link
Contributor

@tomikazi tomikazi commented Dec 3, 2020

No description provided.

@tomikazi tomikazi added the do not merge ⚠️ Do not Merge, used for testing or not ready label Dec 3, 2020
@tomikazi tomikazi removed the do not merge ⚠️ Do not Merge, used for testing or not ready label Dec 3, 2020
Copy link
Contributor

@SeanCondon SeanCondon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my POV - 1 minor comment

pkg/store/snapshot/device/store.go Outdated Show resolved Hide resolved
pkg/device/device.go Outdated Show resolved Hide resolved
@SeanCondon SeanCondon self-requested a review December 7, 2020 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants