Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do replay when watching topo #1250

Merged
merged 2 commits into from Jan 5, 2021
Merged

Do replay when watching topo #1250

merged 2 commits into from Jan 5, 2021

Conversation

SeanCondon
Copy link
Contributor

onos-config calls Watch on onos-topo on connection. This must replay existing entities - with noreplay=true only Entities that are created after startup will arrive in to onos-config.

An alternate approach is to do List first for existing devices and then watch, but this is never satisfactory as there will always be either a gap or an overlap with the 2 methods, with the risk of duplicates or missing entities.

Also I added some filters on Entity events from onos-topo - a version and a kindid are always required for onos-config.

@adibrastegarnia
Copy link
Contributor

We create device simulators here: I think we need to add kind here as well:

return &device.Device{

@SeanCondon
Copy link
Contributor Author

We create device simulators here: I think we need to add kind here as well:

return &device.Device{

Kind is taken from the Type given here - I've ran the gnmi suite and they all pass

@SeanCondon SeanCondon merged commit 5194aee into onosproject:master Jan 5, 2021
@SeanCondon SeanCondon deleted the scWatchTopoWithReplay branch January 5, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants