Introducing Role Based Access Control (RBAC) - build RBAC cache #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanCondon
requested review from
kuujo,
tomikazi,
adibrastegarnia and
scottmbaker
Part 1 of enforcing RBAC - build the RBAC cache
SeanCondon
commented
Feb 11, 2021
| @@ -186,42 +190,6 @@ func GetManager() *Manager { | |||
| return &mgr | |||
| } | |||
|
|
|||
| // ComputeDeviceChange computes a given device change the given updates and deletes, according to the path | |||
| // on the configuration for the specified target | |||
| func (m *Manager) ComputeDeviceChange(deviceName devicetype.ID, version devicetype.Version, | |||
There was a problem hiding this comment.
I just moved this to setconfig.go in the same package - it's only ever used from there so did not need to be in this file
adibrastegarnia
approved these changes
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of enforcing RBAC - build the RBAC cache by listening to events from "rbac" DeviceChanges store
Only do this if authentication is turned on