Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement subscribe poll for the devicesim #248

Merged
merged 2 commits into from
May 30, 2019

Conversation

adibrastegarnia
Copy link
Contributor

@adibrastegarnia adibrastegarnia commented May 29, 2019

1- The devsim supports subscribe poll as well.
2- Porting the gnmi server code to the repo that we add the new features that we need.

@SeanCondon SeanCondon added the enhancement New feature or request label May 29, 2019
@SeanCondon SeanCondon added this to the First Demo milestone May 29, 2019
Copy link
Contributor

@SeanCondon SeanCondon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I ran this - it gives the POLL response every 5 seconds showing Dublin, but when went and changed the TZ value in another terminal to Paris, the POLL event continued giving the old Dublin value. I'd expect it to start transmitting the updated value. Even after restarting the POLL it still displays the old value "Dublin"

@adibrastegarnia
Copy link
Contributor Author

When I ran this - it gives the POLL response every 5 seconds showing Dublin, but when went and changed the TZ value in another terminal to Paris, the POLL event continued giving the old Dublin value. I'd expect it to start transmitting the updated value. Even after restarting the POLL it still displays the old value "Dublin"

Thanks for catching the error. I will take a look to see what is going on.

@adibrastegarnia adibrastegarnia changed the title Implement subscribe poll for the devicesim Implement subscribe poll for the devicesim (WIP) May 29, 2019
@adibrastegarnia adibrastegarnia force-pushed the devsim_subscribe_poll branch 9 times, most recently from f935229 to 4c52090 Compare May 29, 2019 21:57
@adibrastegarnia adibrastegarnia changed the title Implement subscribe poll for the devicesim (WIP) Implement subscribe poll for the devicesim May 29, 2019
@adibrastegarnia
Copy link
Contributor Author

When I ran this - it gives the POLL response every 5 seconds showing Dublin, but when went and changed the TZ value in another terminal to Paris, the POLL event continued giving the old Dublin value. I'd expect it to start transmitting the updated value. Even after restarting the POLL it still displays the old value "Dublin"

@SeanCondon

I addressed your comment and I think this part is ready to merge. Whenever you get a chance, please test it and see will you get the expected output for subscribe poll and once. Thanks

@adibrastegarnia adibrastegarnia changed the title Implement subscribe poll for the devicesim Implement subscribe poll for the devicesim (WIP) May 30, 2019
@adibrastegarnia adibrastegarnia changed the title Implement subscribe poll for the devicesim (WIP) Implement subscribe poll for the devicesim (WIP, DO NOT MERGE) May 30, 2019
@adibrastegarnia adibrastegarnia force-pushed the devsim_subscribe_poll branch 2 times, most recently from ca3b876 to 7b9b4fd Compare May 30, 2019 15:52
@adibrastegarnia adibrastegarnia changed the title Implement subscribe poll for the devicesim (WIP, DO NOT MERGE) Implement subscribe poll for the devicesim May 30, 2019


RUN cd $GOPATH/src/github.com/onosproject/onos-config/tools/test/devicesim/gnmi && go install
RUN cd ./gnmi_target && go install
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gives me a

# _/home/devicesim/gnmi_target
./gnmi_utils.go:115:1: syntax error: non-declaration statement outside function body

@SeanCondon SeanCondon merged commit b208683 into onosproject:master May 30, 2019
@adibrastegarnia adibrastegarnia deleted the devsim_subscribe_poll branch July 23, 2019 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

None yet

2 participants