Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] [cli] ability to specify multiple -focus and -skip flags #735

Closed
kolyshkin opened this issue Nov 6, 2020 · 0 comments · Fixed by #736
Closed

[feature] [cli] ability to specify multiple -focus and -skip flags #735

kolyshkin opened this issue Nov 6, 2020 · 0 comments · Fixed by #736

Comments

@kolyshkin
Copy link
Contributor

kolyshkin commented Nov 6, 2020

I would like to have an ability to specify multiple -focus and -skip flags. Here's why.

Currently, I have something like this in one of the CI files:

-skip=[Slow]|[Serial]|[Disruptive]|[Flaky]|[Feature:.+]|PersistentVolumes|[HPA]|should.support.building.a.client.with.a.CSR|should.propagate.mounts.to.the.host|for.NodePort.service|type.clusterIP|unready.pods|ExternalName.services|Guestbook.application|in-cluster.config|Pods.should.support.pod.readiness.gates|[sig-storage].In-tree.Volumes.[Driver:.local]|[sig-storage].CSI.Volumes.CSI.Topology.test.using.GCE.PD.driver|[sig-storage]\sCSI\sVolumes\s[Driver:\scsi-hostpath]\s[Testpattern:\sDynamic\sPV\s(block\svolmode)]\svolumes\sshould\sstore\sdata|[sig-storage]\sCSI\sVolumes\s[Driver:\scsi-hostpath]\s[Testpattern:\sDynamic\sPV\s(block\svolmode)]\sprovisioning\sshould\sprovision\sstorage\swith\spvc\sdata\ssource|[sig-network]\sServices\sshould\sbe\sable\sto\spreserve\sUDP\straffic\swhen\sserver\spod\scycles\sfor\sa\sNodePort\sservice|Events.should.be.sent.by.kubelets.and.the.scheduler.about.pods.scheduling.and.running|[sig-apps].DisruptionController.should.block.an.eviction.until.the.PDB.is.updated.to.allow.it|[sig-instrumentation].MetricsGrabber

and yes, it's a mess. This, though, can be made much less messy by having something like this instead:

       -skip=\[Slow\]
       -skip=\[Serial\]
       -skip=\[Disruptive\]
       -skip=\[Flaky\]
       -skip=\[Feature:.+\]
       -skip=PersistentVolumes
       -skip=\[HPA\]
       -skip=should.support.building.a.client.with.a.CSR
       -skip=should.propagate.mounts.to.the.host
       -skip=for.NodePort.service
... and so on ...

Implementation-wise it seems quite doable, I think I'll have a PR soon. Hope that would be usable.

Similar idea was already proposed in #550 (comment)

kolyshkin added a commit to kolyshkin/ginkgo that referenced this issue Nov 6, 2020
As an example, now instead of

	... --skip one|two|three|four ...

one can specify

	... \
	--skip one \
	--skip two \
	--skip three \
	--skip four \
	...

which helps readability and maintainability a lot in case there are many
tests to skip.

Fixes onsi#735

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin added a commit to kolyshkin/ginkgo that referenced this issue Nov 6, 2020
As an example, now instead of

	... --skip one|two|three|four ...

one can specify

	... \
	--skip one \
	--skip two \
	--skip three \
	--skip four \
	...

which helps readability and maintainability a lot in case there are many
tests to skip.

Fixes onsi#735

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin added a commit to kolyshkin/ginkgo that referenced this issue Nov 6, 2020
As an example, now instead of

	... --skip one|two|three|four ...

one can specify

	... \
	--skip one \
	--skip two \
	--skip three \
	--skip four \
	...

which helps readability and maintainability a lot in case there are many
tests to skip.

Fixes onsi#735

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@onsi onsi closed this as completed in #736 Jan 11, 2021
onsi pushed a commit that referenced this issue Jan 11, 2021
As an example, now instead of

	... --skip one|two|three|four ...

one can specify

	... \
	--skip one \
	--skip two \
	--skip three \
	--skip four \
	...

which helps readability and maintainability a lot in case there are many
tests to skip.

Fixes #735

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant