Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in internal/suite.go #1332

Merged
merged 2 commits into from Jan 5, 2024
Merged

Fix typo in internal/suite.go #1332

merged 2 commits into from Jan 5, 2024

Conversation

shubham14bajpai
Copy link
Contributor

I saw this error message with a small spelling mistake while writing tests.

cnanot clone suite after tree has been built

This PR fixes the same.

@blgm
Copy link
Collaborator

blgm commented Jan 5, 2024

Thank you @shubham14bajpai. This is a good improvement, but unfortunately the tests fail because they are expecting the typo!

  [FAILED] Expected
      <*errors.errorString | 0xc0002a81f0>: 
      cannot clone suite after tree has been built
      {
          s: "cannot clone suite after tree has been built",
      }
  to match error
      <string>: cnanot clone suite after tree has been built
  In [It] at: /home/runner/work/ginkgo/ginkgo/internal/suite_test.go:91 @ 01/05/24 11:01:59.47

Do you want to update the test too? If you don't have the time then I'm happy to do it, but wanted to give you the choice.

@shubham14bajpai
Copy link
Contributor Author

Thank you @shubham14bajpai. This is a good improvement, but unfortunately the tests fail because they are expecting the typo!

  [FAILED] Expected
      <*errors.errorString | 0xc0002a81f0>: 
      cannot clone suite after tree has been built
      {
          s: "cannot clone suite after tree has been built",
      }
  to match error
      <string>: cnanot clone suite after tree has been built
  In [It] at: /home/runner/work/ginkgo/ginkgo/internal/suite_test.go:91 @ 01/05/24 11:01:59.47

Do you want to update the test too? If you don't have the time then I'm happy to do it, but wanted to give you the choice.

Sure I will update the test as well 👍

@blgm blgm merged commit beb9507 into onsi:master Jan 5, 2024
6 checks passed
@blgm
Copy link
Collaborator

blgm commented Jan 5, 2024

Thanks @shubham14bajpai!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants