Update fixtures to work using go1.10 #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In go 1.10 the `-coverpkg` flag does not load new packages, but allow users to provide a list of patterns (see https://golang.org/doc/go1.10#test). For this reason, we need to import the package in the fixture.
nodo
force-pushed
the
go-1.10-coverage-test
branch
from
01f01f6
to
e37dbfe
Compare
|
For context, this PR fixes a red test in go 1.10 (see here) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In go 1.10 the
-coverpkgflag does not load new packages, but allowusers to provide a list of patterns (see
https://golang.org/doc/go1.10#test). For this reason, we need to import
the the package in the fixture.