Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make HaveEach error in case of nil/empty actual val #524

Merged
merged 1 commit into from Feb 28, 2022

Conversation

thediveo
Copy link
Collaborator

@thediveo thediveo commented Feb 28, 2022

relates to issue #520 and defines the HaveEach matcher behavior for empty arrays/slices/maps.

  • HaveEachMatcher errors for empty actual value
  • update unit tests
  • update documentation and include example when empty actuals are acceptable

- HaveEachMatcher errors for empty actual value
- update unit tests
- update documentation and include example when empty actuals are acceptable
@onsi
Copy link
Owner

onsi commented Feb 28, 2022

Makes sense, good catch!

@onsi onsi merged commit c8ba582 into onsi:master Feb 28, 2022
4 checks passed
@thediveo thediveo deleted the have-each-up branch Feb 28, 2022
@thediveo thediveo mentioned this pull request Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants