Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session timer #213

Closed
wants to merge 4 commits into from
Closed

Session timer #213

wants to merge 4 commits into from

Conversation

vassjozsef
Copy link

No description provided.

@wakamoleguy
Copy link
Contributor

Hey, I haven't had time to look closely at this, and I just wanted to thank you for the PR and for being patient with us on merging it. New features like this will have to go through a little more consideration and likely some tuning before being merged into the core library.

@james-criscuolo
Copy link
Collaborator

Hi @vassjozsef,
Has this been tested at all? I looked this over with @joseph-onsip offline for a few minutes, and he explained that his initial commits were scratch work and needed testing.

An example of this code working in production would be good, but some tests added to our jasmine testing set would be better. Both of those together would be ideal.

Thanks,
James

@vassjozsef
Copy link
Author

Yes, it is has been tested, it is running in our production. I will add tests.

@josephfrazier
Copy link
Contributor

@vassjozsef, have you made any progress with the tests?

@james-criscuolo
Copy link
Collaborator

This work has been added to and is now being tracked here:

https://github.com/onsip/SIP.js/tree/session-timers

The current status of the branch is very much a work in progress, but it is a bit more fleshed out to cover more session timer features. I will be closing this, as the PR itself is no longer most up to date, but we will be tracking progress from the original issue:

#18

Thanks,
James

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants