Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Session Timers #18

Open
egreenmachine opened this issue May 19, 2014 · 6 comments
Open

Handle Session Timers #18

egreenmachine opened this issue May 19, 2014 · 6 comments

Comments

@egreenmachine
Copy link
Collaborator

FreeSwitch by default has Session Timeouts in the SIP headers. This header is documented in RFC4028

Session-Expires: 120;refresher=uas

The re-invites from FreeSwitch have identical SDP to what it sent on the original 200 OK (answer to the INVITE). We should be able to handle it by just sending a 200 OK with the SDP from the original INVITE. No ports or IP addresses have changed.

One potential issue I could see with this is if FreeSwitch decides to update the SDP to use a different IP address or Port. SIP.js has no way of updating the Peer Connection

@josephfrazier
Copy link
Contributor

Note: this was reported in the Google Group: https://groups.google.com/forum/#!msg/sip_js/hzoMQ-xXIko/ZhTbocagi-oJ

@josephfrazier
Copy link
Contributor

Putting this on the back burner for now. Partial work has been pushed to my sessiontimers branch, if anyone is interested in picking it up.

@josephfrazier josephfrazier removed their assignment Oct 16, 2014
@wakamoleguy wakamoleguy added this to the 0.8.0 milestone Nov 24, 2014
@markandrus
Copy link
Contributor

@joseph-onsip there are a few commits on your branch that it looks like it would be nice to have in master, namely

any chance of getting those merged in, even before full session timer support is ready?

@josephfrazier
Copy link
Contributor

Hey @markandrus, sorry for the latency on this. I've created #203 on your behalf, so the changes can be considered there.

@james-criscuolo
Copy link
Collaborator

Some work was done here, and is pushed on this branch:

https://github.com/onsip/SIP.js/tree/session-timers

The branch is a work in progress, but we hope it at least hits all the features we are looking to incorporate here.

@egreenmachine egreenmachine removed this from the 0.8.0 milestone Nov 17, 2017
@digitaldan
Copy link

Any updates or workarounds for this?

prlanzarin added a commit to prlanzarin/SIP.js that referenced this issue Jan 14, 2020
Correctly clear custom register contexts on unregister
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants