Session: on re-INVITE, send 488 instead of calling this.receiveReinvite #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joseph-onsip, you have permission to push these yourself, you know. :-) Anyways, I'd say that while this stops things from crashing, the intention of #18 is to actually implement and react accordingly to session refreshment (note the enhancement tag), and so this doesn't resolve that issue. |
|
Oh, good point about #18. That's why I don't just push this stuff, so other people can catch my mistakes (had I pushed it, it would have been with a commit message that closes issues 18 and 19). |
josephfrazier
pushed a commit
that referenced
this pull request
Jun 26, 2014
Session: on re-INVITE, send 488 instead of calling this.receiveReinvite fixes #19
josephfrazier
pushed a commit
to josephfrazier/SIP.js
that referenced
this pull request
May 13, 2015
josephfrazier
pushed a commit
to josephfrazier/SIP.js
that referenced
this pull request
May 13, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #19 (comment)
I tested this against a conference call using Freeswitch 1.5.11 installed as described on sipjs.com, received and rejected the re-invites, and was able to remain in the conference for several multiples of the
Session-Expiresheader's value afterwards. I didn't receive any more re-invites, so I think rejecting the first one successfully tells Freeswitch we don't currently support session timers.This also prevents non-timer renegotiation (example: hold), which seems ok since the browsers don't currently have general support for it. See #19 (comment)
fixes #19