Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add asset api support #1062

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

add asset api support #1062

wants to merge 17 commits into from

Conversation

tanZiWen
Copy link
Collaborator

No description provided.

carltraveler and others added 15 commits June 20, 2019 18:39
* add block height check when run transaction

* finetune the config height

* update blockheight, estimate by ((two weeks block) * 2 + current blockheight)

* make pickitem support both big.int and bytearray. ensure big.int do not expose to user

* update opcode hight constant to future block
* fix Vbft Block serdes

* enforce merkleRoot data in Block msg

* fix error handlings
* add repeat tx check in p2p

* add lru cache to save tx in Link

* gofmt

* move duplicate tx check to TransactionHandle

* fix checkDuplicateTx bug

* go fmt

* change printf fmt

* change txCache init

* refactor code

* change store tx to store txhash
* make no mask if addr request is from masked peers

* update addr-req testcase
* update neovm new opecode height restriction

* fixed testnet neovm opcode height
* add go.mod

* add golang.org/x/text and tools

* update travis for gomod

* fix .travis.yml, build image firstly

* add GO111MODULE to travis config

* format peer_pool.go with gofmt v1.12.x

* remove .travis script test on windows
* add check block height for pickitem opcode

* move block strict to neovm engine structure
@@ -104,6 +104,7 @@ var (
RUNTIME_ADDRESSTOBASE58_NAME = "Ontology.Runtime.AddressToBase58"
RUNTIME_GETCURRENTBLOCKHASH_NAME = "Ontology.Runtime.GetCurrentBlockHash"
RUNTIME_VERIFYMUTISIG_NAME = "Ontology.Runtime.VerifyMutiSig"
RUNTIME_ASSERT_NAME = "Ontology.Runtime.Assert"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assert api maybe confused with the python original keyword "assert". suguest OntAssert

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@laizy
Copy link
Contributor

laizy commented Aug 29, 2019

breaking change need add effective height check for testnet and mainnet.

@tanZiWen
Copy link
Collaborator Author

it's unnecessary to do that. it doesn't a function which has existed.

@laizy
Copy link
Contributor

laizy commented Aug 29, 2019

I am afraid not, if compiler is ready, someone can deploy the code to testnet and mainnet at any time.

@tanZiWen
Copy link
Collaborator Author

the compiler won't publish this function until this function has been launched on testnet and mainnet.

@Honglei-Cong Honglei-Cong changed the title add assert api support add asset api support Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants