-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modify stackitem equals #427
Conversation
asymmetry implementation may cause |
smartcontract/test/panic_test.go
Outdated
@@ -65,7 +65,7 @@ func TestRandomCodeCrash(t *testing.T) { | |||
//cache := storage.NewCloneCache(testBatch) | |||
sc := SmartContract{ | |||
Config: config, | |||
Gas: 10000, | |||
Gas: 0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why modify this?
return false | ||
} | ||
|
||
return reflect.DeepEqual(this._array, oa) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is unsound. Equals
on ByteArray, Integer and Bool
now is type-erased, but DeepEqual
is not.
No description provided.