Add more efficient mode for reduce when only considering named classes.
#619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balhoff
changed the title
reduce when only considering named classes.
|
Looks good to me. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is prompted by a failure GO had when trying to update to a newer ROBOT version. The
reducecommand was failing to complete on the large go-lego ontology. This additional implementation walks the reasoner taxonomy, and so is more efficient than the previous approach, but it is also limited to only considering subclass axioms between named classes (there are some corner cases where the approach of generating a name for the anonymous expressions doesn't work with the new algorithm). There is a new command-line option--named-classes-onlyto engage the faster version.