Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Whelk reasoner. #730

Merged
merged 3 commits into from
Sep 14, 2020
Merged

Add Whelk reasoner. #730

merged 3 commits into from
Sep 14, 2020

Conversation

balhoff
Copy link
Contributor

@balhoff balhoff commented Sep 9, 2020

Add Whelk as a reasoner choice.

  • docs/ have been added/updated
  • tests have been added/updated
  • mvn verify says all tests pass
  • mvn site says all JavaDocs correct
  • CHANGELOG.md has been updated

@jamesaoverton
Copy link
Member

My only concern is increasing the size of the binary by ~15%:

branch link size
master https://build.obolibrary.io/job/ontodev/job/robot/job/master/ 62.36 MB
whelk https://build.obolibrary.io/job/ontodev/job/robot/job/whelk/ 72.39 MB

What are the key benefits of Whelk for ROBOT?

@balhoff
Copy link
Contributor Author

balhoff commented Sep 9, 2020

My only concern is increasing the size of the binary by ~15%

This was surprising to me, since Whelk is tiny and I have tried to keep the dependencies minimal. The core has only one dependency (scalaz-core) which is used for a couple small things; it turns out it's a lot bigger than I realized! scalaz-core accounts for pretty much all of that. I'll just re-implement the one method I'm using—hold off until I update this PR.

What are the key benefits of Whelk for ROBOT?

Whelk provides a combination of OWL features not available together in any of the other reasoners:

  • EL scalability (albeit slower than ELK)
  • better support for Self restrictions than ELK, supporting rolification
  • some classification for unions
  • object property assertion materialization
  • OWL RL features for Abox
  • SWRL rules (class and object property atoms)

Whelk is also much faster than ELK at answering DL queries, but I don't think this will be apparent in the current ROBOT commands.

@jamesaoverton
Copy link
Member

Thanks. Now I see 63.00 MB.

The changes look good. I want to try it out on a couple of things before merging.

@beckyjackson beckyjackson merged commit 31ce3ed into master Sep 14, 2020
@beckyjackson beckyjackson deleted the whelk branch September 14, 2020 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants