961 folder creation #1012
Merged
961 folder creation #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def persisted? | ||
| false | ||
| end | ||
|
|
There was a problem hiding this comment.
Style/EmptyLinesAroundBody: Extra empty line detected at body end.
eugenk
force-pushed
the
961-folder_creation
branch
from
c167f4f
to
c3ddd29
Compare
eugenk
force-pushed
the
961-folder_creation
branch
from
c3ddd29
to
8c3bff5
Compare
| @@ -0,0 +1,35 @@ | |||
| class RepositoryDirectoriesController < InheritedResources::Base | |||
There was a problem hiding this comment.
Style/FileName: Use snake_case for source file names.
eugenk
force-pushed
the
961-folder_creation
branch
from
8c3bff5
to
e9bd8ac
Compare
eugenk
force-pushed
the
961-folder_creation
branch
from
e9bd8ac
to
230a45d
Compare
| protected | ||
|
|
||
| def resource | ||
| @repository_directory ||= RepositoryDirectory.new(params.merge(user: current_user)) |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [87/80]
eugenk
force-pushed
the
961-folder_creation
branch
from
230a45d
to
ac98604
Compare
| target_filename | ||
| else | ||
| temp_file.original_filename | ||
| end |
There was a problem hiding this comment.
Lint/EndAlignment: end at 118, 4 is not aligned with if at 114, 15
eugenk
force-pushed
the
961-folder_creation
branch
from
ac98604
to
6d51db2
Compare
Woof woof!
The 'Create subdirectory' button now adds a line to the file browser containing a form. When this form is sent, an XHR is sent. If the directory could be created, the form is replaced by a link. Otherwise an error message is shown. The user can show as many forms as he wants.
This was originally bringit code that showed information on the last commit of each file in the file browser. This was deactivated (but not entirely deleted) because of serious performance issues on big repositories.
eugenk
force-pushed
the
961-folder_creation
branch
from
5deb5f8
to
f95f01c
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #961