795 delete repository asynchonously #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,7 +6,7 @@ class HomeController < ApplicationController | |||
| def index | |||
| @comments = Comment.latest.limit(10).all | |||
| @versions = OntologyVersion.latest.where(state: 'done').limit(10).all | |||
| @repositories = Repository.accessible_by(current_user).latest.limit(10).all | |||
| @repositories = Repository.active.accessible_by(current_user).latest.limit(10).all | |||
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [86/80]
eugenk
force-pushed
the
795-delete_repository_asynchonously
branch
from
e8ea1c6
to
a01d764
Compare
eugenk
force-pushed
the
795-delete_repository_asynchonously
branch
from
a01d764
to
1578ed2
Compare
|
|
||
| def is_destroying? | ||
| self.class.instance_variable_get(:@destroying).include?(self.id) | ||
| class Repository::Error < StandardError; end |
There was a problem hiding this comment.
Style/ClassAndModuleChildren: Use nested module/class definitions instead of compact style.
eugenk
force-pushed
the
795-delete_repository_asynchonously
branch
3 times, most recently
from
88e4fad
to
89a1929
Compare
| @@ -37,6 +37,6 @@ def filters_map | |||
| private | |||
|
|
|||
| def repository | |||
| Repository.find_by_path params[:repository_id] | |||
| Repository.active.find_by_path params[:repository_id] | |||
There was a problem hiding this comment.
please add the missing parentheses.
eugenk
force-pushed
the
795-delete_repository_asynchonously
branch
2 times, most recently
from
237763d
to
f50cbbd
Compare
| @@ -11,7 +11,12 @@ class Repository < ActiveRecord::Base | |||
| include Repository::Symlink | |||
| include Repository::Validations | |||
|
|
|||
| <<<<<<< HEAD | |||
eugenk
force-pushed
the
795-delete_repository_asynchonously
branch
from
f50cbbd
to
34fec7a
Compare
eugenk
force-pushed
the
795-delete_repository_asynchonously
branch
2 times, most recently
from
a208f1c
to
e923e3e
Compare
| def unmark_as_destroying | ||
| self.class.instance_variable_get(:@destroying).delete(self.id) if self.id | ||
| def can_be_deleted? | ||
| ontologies.map(&:can_be_deleted_with_whole_repository?).all? |
There was a problem hiding this comment.
Why don't you use each so you don't have to run over all ontologies?
There was a problem hiding this comment.
Good point. I seem to have been in lazy Haskell mode.
I could have introduced a default scope, but this would result in broken migrations: Some migrations change existing repositories. They would fail at selecting repositories because there is no column 'destroying'. Also default scopes cannot be overridden.
When destroying a repository asynchronously, we don't need to mark it as destroying in a class instance variable any more. Instead, we mark it in the database.
This reverts commit d053813. Conflicts: app/controllers/home_controller.rb app/controllers/ontology_search_controller.rb app/helpers/application_helper.rb app/models/repository/destroying.rb
Repositories marked as deleted shall still be browseable by the owner. If there is a default scope, many controllers and other parts of ontohub fail finding such a repo.
eugenk
force-pushed
the
795-delete_repository_asynchonously
branch
from
c9ba3f7
to
15c14e6
Compare
eugenk
added a commit
that referenced
this pull request
Mar 2, 2015
…usly 795 delete repository asynchonously
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shall fix #795 and #342.
I created this branch on top of #1026, not on top of staging.