634 fork and unmirror repository #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
|
|
||
| # executes a pull/clone job | ||
| def remote_send(method) | ||
| def remote_send(method, remote_type=nil) |
There was a problem hiding this comment.
Metrics/MethodLength: Method has too many lines. [17/10]
Style/SpaceAroundEqualsInParameterDefault: Surrounding space missing in default value assignment.
eugenk
force-pushed
the
634-fork_and_unmirror_repository
branch
from
9d5f197
to
8a41c94
Compare
|
|
||
| before_validation ->{ detect_source_type } | ||
| after_create ->{ async_remote :clone }, if: :mirror? | ||
| before_validation ->{ detect_source_type if new_record? } |
There was a problem hiding this comment.
Style/SpaceBeforeBlockBraces: Space missing to the left of {.
eugenk
force-pushed
the
634-fork_and_unmirror_repository
branch
from
d01d2c2
to
583aae2
Compare
|
|
||
| before_validation ->{ detect_source_type } | ||
| after_create ->{ async_remote :clone }, if: :mirror? | ||
| before_validation ->() do |
There was a problem hiding this comment.
Style/Lambda: Use the lambda method for multi-line lambdas.
eugenk
force-pushed
the
634-fork_and_unmirror_repository
branch
3 times, most recently
from
2fcf7ca
to
2324b05
Compare
eugenk
force-pushed
the
634-fork_and_unmirror_repository
branch
from
2324b05
to
4dc9d14
Compare
| @@ -12,7 +12,8 @@ def create | |||
| end | |||
|
|
|||
| def update | |||
| params[:repository].except!(:source_address, :source_type, :name) | |||
| resource.convert_to_local! if params[:un_mirror] | |||
| params[:repository].except!(:source_address, :source_type, :remote_type, :name) | |||
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [83/80]
eugenk
force-pushed
the
634-fork_and_unmirror_repository
branch
from
54a4b3d
to
7ca499c
Compare
| let(:repository) { create :repository, | ||
| source_address: 'http://some_source_address.example.com', | ||
| source_type: 'git', | ||
| remote_type: 'mirror' } |
eugenk
force-pushed
the
634-fork_and_unmirror_repository
branch
from
30dcf0f
to
b046e9a
Compare
|
👍 |
|
Please rebase Staging in it to make it mergeable before closing this pull request |
eugenk
force-pushed
the
634-fork_and_unmirror_repository
branch
from
bf6bd9a
to
5db1056
Compare
|
Done, but there were merge conflicts in the |
eugenk
force-pushed
the
634-fork_and_unmirror_repository
branch
from
5db1056
to
b3d49d7
Compare
|
👍 |
eugenk
added a commit
that referenced
this pull request
Feb 1, 2015
634 fork and unmirror repository
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shall fix both issues of #634 (and #351): Allowing to fork a repository and converting a mirror to a local repository.
This also improves the javascript in the new repository view as it now updates everytime the source address is changed (key press, click, cut, paste) and not only when its input field loses focus.