Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add i18n tasks gem #1042

Merged
merged 5 commits into from
Oct 20, 2014
Merged

Add i18n tasks gem #1042

merged 5 commits into from
Oct 20, 2014

Conversation

SGraef
Copy link
Member

@SGraef SGraef commented Sep 15, 2014

To get an better overview of our localizations we want to have the i18n-task gem


it 'does not have missing keys' do
expect(missing_keys).to be_empty,
"Missing #{missing_keys.leaves.count} i18n keys, run `i18n-tasks missing' to show them"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code style: too much indentation

@SGraef
Copy link
Member Author

SGraef commented Sep 19, 2014

I ignore them because we call them not explicit so the gem didn't realised that we use them

@eugenk
Copy link
Member

eugenk commented Oct 12, 2014

Apart from the indentation comments: 👍

SGraef pushed a commit that referenced this pull request Oct 20, 2014
@SGraef SGraef merged commit 4115424 into staging Oct 20, 2014
@0robustus1 0robustus1 deleted the add_i18n-tasks_gem branch March 9, 2015 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants