Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display global issue link only if necessary #1047

Merged
merged 11 commits into from
Oct 24, 2014

Conversation

SGraef
Copy link
Member

@SGraef SGraef commented Sep 22, 2014

should fix #689

TERMINAL_STATES = %w(failed done)

STATE_LABEL={pending: 'label-warning',
fetching: 'label-primary',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/AlignHash: Align the elements of a hash literal if they span more than one line.

TERMINAL_STATES = %w(failed done)

STATE_LABEL = {pending: 'label-warning',
fetching: 'label-primary',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/AlignHash: Align the elements of a hash literal if they span more than one line.

TERMINAL_STATES = %w(done failed)

STATE_LABEL = {
pending: 'label-warning',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/IndentHash: Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.

@eugenk
Copy link
Member

eugenk commented Oct 20, 2014

👍

@SGraef SGraef force-pushed the 689-show_oops_global_issues_correctly branch from 428c740 to 7991a5f Compare October 20, 2014 09:49
@SGraef SGraef force-pushed the 689-show_oops_global_issues_correctly branch from 7991a5f to 4d187c0 Compare October 23, 2014 10:59
SGraef pushed a commit that referenced this pull request Oct 24, 2014
…rectly

Display global issue link only if necessary
@SGraef SGraef merged commit c8eeb60 into staging Oct 24, 2014
@0robustus1 0robustus1 deleted the 689-show_oops_global_issues_correctly branch March 9, 2015 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only show "OOPS global issues" link if there are global issues
4 participants