262 use hets api #1057
Merged
262 use hets api #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| def set_up_state | ||
| version = check_up_state | ||
| self.up = !! version |
There was a problem hiding this comment.
Style/SpaceAfterNot: Do not leave space between ! and its argument.
There was a problem hiding this comment.
Not really a not, but a booleanifier, so it is ok ;)
0robustus1
force-pushed
the
262-use_hets_api
branch
2 times, most recently
from
2a76c23
to
3b783c9
Compare
| end | ||
|
|
||
| def fetch_pid | ||
| pid = nil |
There was a problem hiding this comment.
Because i would've had a hard time returning pid from the method without first initializing it.
|
👍 |
1 similar comment
|
👍 |
0robustus1
force-pushed
the
262-use_hets_api
branch
from
9ac0470
to
f81e701
Compare
MIME-Router will allow to filter based on mime-accepts-header and GroupedConstraint will allow to include multiple Constraint in an 'and' fashion (all constraints need to be return true).
In the html-case just perform show action. In the plain case send the ontology-file as download.
The iri link (which displays the iri of an ontology) now actually links to the iri. And the download-link has moved as a button next to the evaluate button.
It seems due to old fixtures we did not realize that our annotation mechanic wasn't working properly anymore. However the problem is fixed (we can't rely on entity-uris in angle brackets anymore) and the spec has been updated for the hets-api.
This includes a rather crude fix to allow the hets-api stubbing to occur for multiple files by checkinf for part of their filename. This should work, but we should take care when creating a test which needs this behaviour.
This spec needs stubbing based on the specific commit, as there are two commits to the same file. I currently do not know how to test this, this is why the test is marked as skipped/pending.
This task will also create the fixture-files.
In versioned iris the normal iri route is prefixed by a ref/:version_number in order to fetch the state of a specific version of that ontology-(member).
This should allow iri-finding with ignoring the hostname-schema prefix. It is not perfect, but it'll work until we've change the iri-storing system.
In order to be capable to process multiple commits of the same ontology at once, we'll need to use the versioned iri.
This is to circumvent development problems with the hets-api.
Also fix problems regarding the mass-commiting (for each it-block) into the factory-repository at least in this spec. We need to find a more general solution.
- Use no spaces between content and Hash-braces - Set Collection Methods correctly - Deactivate snake-case check because it is erroneous.
In order to prevent problems call basepath and path on the version if possible.
As per eugens [comment][1] this remove the after-block, as repository is now done via a *global* after-hook in the spec-helper. [1]: b606786#commitcomment-7992278
0robustus1
force-pushed
the
262-use_hets_api
branch
from
f81e701
to
04f3ae5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sorry, this is a huge one...
Shall fix #262. Shall also fix #1045 and #516.
I'll try to sum up some points of issue:
ontology_version.number)find_with_irito perform a like/postfix search.What is missing?