694 priority for small pushes #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| schedule_batch_parsing(versions) | ||
| priority = applicable_for_priority?(commits_count, highest_change_file_count) |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [81/80]
0robustus1
force-pushed
the
694-priority_for_small_pushes
branch
from
26cacb7
to
00ef87a
Compare
| } | ||
|
|
||
| schedule_batch_parsing(versions) | ||
| priority = applicable_for_priority?(commits_count, highest_change_file_count) |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [81/80]
See information about the rules here: #694 (comment).
The OntologyBatchParseWorker now can take method calls which directly supply the queue to place the job in. Additionally there is a convience method for the priority-push queue.
Add a method to check whether the necessary priority conditions are met. Additionally add a helper method to retrieve the specific settings.
Add specs to ensure that future jobs (concurrency balancing) will stay on the queue they started out at (with the exception of the sequential jobs, which have their own queue).
In the case of small pushes suspended_save_ontologies should create the jobs accordingly.
The deprecation warnings with regard to be_true have been turned into be(true).
Per eugens 'suggestion' i'll use allow_any_instance and the receive mocker.
Per eugens suggestion we will now test every bound of the 'small push priority'-system.
0robustus1
force-pushed
the
694-priority_for_small_pushes
branch
from
bd77833
to
1d010a8
Compare
|
👍 |
0robustus1
added a commit
that referenced
this pull request
Oct 20, 2014
694 priority for small pushes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shall fix #694.
See the settings.yml for the related settings.