286 switch from solr to elastic search #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
|
|
There was a problem hiding this comment.
Style/EmptyLinesAroundBody: Extra empty line detected at body end.
|
please change the travis.yml file according to the changes that elasticsearch instead of solr will be started |
| include Elasticsearch::Model::Callbacks | ||
|
|
||
| mapping do | ||
| indexes :name, type: 'string', :analyzer => 'snowball' |
There was a problem hiding this comment.
Style/HashSyntax: Use the new Ruby 1.9 hash syntax.
ebolloff
force-pushed
the
286-switch_from_solr_to_elastic_search
branch
3 times, most recently
from
d5d67e3
to
56af861
Compare
|
|
||
| if in_repository? | ||
| respond_with OntologySearch.new.make_repository_keyword_list_json(repository, prefix) | ||
| def search |
There was a problem hiding this comment.
Metrics/CyclomaticComplexity: Cyclomatic complexity for search is too high. [7/6]
Metrics/MethodLength: Method has too many lines. [22/10]
Metrics/PerceivedComplexity: Perceived complexity for search is too high. [8/7]
added 15 commits
December 1, 2014 15:33
Present also checks for nil, empty only checks for emptiness.
If there's a change in an ontology, the indexing will be updated.
ebolloff
force-pushed
the
286-switch_from_solr_to_elastic_search
branch
from
5a474ed
to
8d103e2
Compare
added 2 commits
December 1, 2014 16:14
Fix port for testing elasticsearch.
0robustus1
force-pushed
the
286-switch_from_solr_to_elastic_search
branch
3 times, most recently
from
6cc7819
to
72de428
Compare
But on our local machines we'll use 9250 and the test-cluster.
0robustus1
force-pushed
the
286-switch_from_solr_to_elastic_search
branch
from
72de428
to
daa05c1
Compare
|
👍 |
ebolloff
added a commit
that referenced
this pull request
Dec 2, 2014
…_search 286 switch from solr to elastic search
This was referenced Dec 6, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should do the first fixes for the search with elasticsearch instead of solr