Add named logic iris #1095
Merged
Add named logic iris #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.slug = name.gsub(/[\s*.=]/, '_') | ||
| save! | ||
| end | ||
|
|
There was a problem hiding this comment.
Style/EmptyLinesAroundBody: Extra empty line detected at body end.
The slug is used as the param portion of a logic-url. It represents a 'cleaner' name where whitespace is replaced with underscores. Additionally we also replace dots, stars and equality signs with underscores.
This migration should contain a safeguard which should ensure that this never fails (unless there is no logic class i guess...).
0robustus1
force-pushed
the
add_named_logic_iris
branch
from
d0c785a
to
a71beaa
Compare
|
|
||
| private | ||
| def set_slug | ||
| self.slug = name.gsub(/[\s*.=]/, '_') |
There was a problem hiding this comment.
please replace = by Eq, * by Star
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The title pretty much says it all, allow logic-urls to contain the (cleaned) name instead of the numbered id.