446 new ontohub oms generalization #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -75,7 +75,7 @@ def show | |||
|
|
|||
| def destroy | |||
| if resource.is_imported? | |||
| flash[:error] = "Can't delete an ontology that is imported by another one." | |||
| flash[:error] = "Can't delete an #{Settings.OMS} that is imported by another one." | |||
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [88/80]
|
please address the issues found by hound |
|
we need to get this long story to an end. Please solve all remaining points until Wednesday. The travis issue is caused by a wrong fixture and will be fixed by someone else quickly. |
hardik101
force-pushed
the
446-new_ontohub_oms_generalization
branch
from
7faba4e
to
03cf757
Compare
| @@ -24,7 +24,7 @@ def show | |||
| end | |||
| end | |||
| rescue Errno::ENOENT, NoMethodError => e | |||
| redirect_to collection_path, flash: { error: "The file was not found: #{e.message}" } | |||
| redirect_to collection_path, flash: {error: "The file was not found: #{e.message}"} | |||
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [87/80]
| - else | ||
| = link_to "show only Logics with Ontologies", logics_path | ||
| = link_to "show only logics with "+Settings.OMS.pluralize, logics_path |
There was a problem hiding this comment.
Please prefer String interpolation.
hardik101
force-pushed
the
446-new_ontohub_oms_generalization
branch
from
f7b0a64
to
16183b5
Compare
| @@ -24,7 +24,10 @@ def show | |||
| end | |||
| end | |||
| rescue Errno::ENOENT, NoMethodError => e | |||
| redirect_to collection_path, flash: { error: "The file was not found: #{e.message}" } | |||
| redirect_to collection_path | |||
| ,flash: { | |||
hardik101
force-pushed
the
446-new_ontohub_oms_generalization
branch
from
16183b5
to
0a4c9ec
Compare
| redirect_to collection_path, flash: { error: "The file was not found: #{e.message}" } | ||
| redirect_to collection_path, | ||
| flash: { | ||
| error: "The file was not found: #{e.message}" |
There was a problem hiding this comment.
Style/TrailingComma: Put a comma after the last item of a multiline hash.
|
👍 |
hardik101
added a commit
that referenced
this pull request
Nov 22, 2014
446 new ontohub oms generalization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is clean pull request without any mixed commit w.r.t indefinite article.