1087 correct indefinite article for oms #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -75,7 +75,7 @@ def show | |||
|
|
|||
| def destroy | |||
| if resource.is_imported? | |||
| flash[:error] = "Can't delete an ontology that is imported by another one." | |||
| flash[:error] = "Can't delete an #{Settings.OMS.with_indefinite_article} that is imported by another one." | |||
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [112/80]
hardik101
force-pushed
the
1087-correct_indefinite_article_for_OMS
branch
from
0254b5c
to
bbfbfcc
Compare
| @@ -14,7 +14,8 @@ def destroy | |||
| super | |||
| rescue StandardError => e | |||
| unmark_as_destroying | |||
| raise e.class, "Can't delete repository: It contains an ontology that is imported by another repository." | |||
| raise e.class, "Can't delete repository: It contains \ | |||
| #{Settings.OMS.with_indefinite_article} that is imported by another repository." | |||
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [84/80]
hardik101
force-pushed
the
1087-correct_indefinite_article_for_OMS
branch
from
bbfbfcc
to
64b41cb
Compare
| @@ -14,7 +14,8 @@ def destroy | |||
| super | |||
| rescue StandardError => e | |||
| unmark_as_destroying | |||
| raise e.class, "Can't delete repository: It contains an #{Settings.OMS} that is imported by another repository." | |||
| raise e.class, "Can't delete repository: It contains | |||
There was a problem hiding this comment.
Style/TrailingWhitespace: Trailing whitespace detected.
hardik101
force-pushed
the
1087-correct_indefinite_article_for_OMS
branch
from
64b41cb
to
52e5140
Compare
eugenk
force-pushed
the
1087-correct_indefinite_article_for_OMS
branch
from
52e5140
to
d50b235
Compare
eugenk
force-pushed
the
1087-correct_indefinite_article_for_OMS
branch
from
d50b235
to
b14a891
Compare
|
I just rebased staging. In my opinion, it's a 👍 |
hardik101
added a commit
that referenced
this pull request
Feb 1, 2015
…_for_OMS 1087 correct indefinite article for oms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added new gem and used its method 'with_indefinite_article' for all the found instances where it can be applied.