1099 label symbols in obo sentences #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is solved by just calling set_display_text! on the sentences at the right time (after the display_name for the symbol has been updated).
Add the migration the update the display_text of already existing obo sentences.
| @@ -2,17 +2,18 @@ module Sentence::Readability | |||
| extend ActiveSupport::Concern | |||
|
|
|||
| def set_display_text! | |||
| new_text = self.text.dup | |||
| if text | |||
There was a problem hiding this comment.
Style/GuardClause: Use a guard clause instead of wrapping the code inside a conditional expression.
0robustus1
force-pushed
the
1099-label_symbols_in_obo_sentences
branch
from
054ce42
to
8d5ebe2
Compare
|
👍 as soon as travis is green |
0robustus1
added a commit
that referenced
this pull request
Dec 6, 2014
…nces 1099 label symbols in obo sentences
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shall fix #1099.
However a test on develop.ontohub.org for the migration was not possible, as the obo-ontologies there seem broken.