28 remote file upload #1139
Merged
28 remote file upload #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| render json: filetype_json | ||
| rescue Hets::HetsError | ||
| render json: {status: 415, message: 'Media Type not supported'}, | ||
| status: 415 |
There was a problem hiding this comment.
Style/AlignHash: Align the elements of a hash literal if they span more than one line.
0robustus1
force-pushed
the
28-remote_file_upload
branch
from
067546d
to
eee9475
Compare
| when 'local' | ||
| temp_file.original_filename | ||
| when 'remote' | ||
| remote_file_iri.split('/').last |
There was a problem hiding this comment.
What if the iri has a query string or ends on /?
There was a problem hiding this comment.
- ends on
/: we don't care assplitwill take care of this (a lone/at the end will just be dropped) - contains query-string: i will fix that.
|
Entering the remote address |
In order to decide how the HTTP response of a Hets::Caller should be served, we'll use speaking constant names.
This adds a module-method on the Hets module to determine the filetype for a resource which responds to the versioned_iri method.
There are some strange lookup errors otherwise.
As only one of the two needs to be provided, we had to change the validations (and add a validation for the remote file iri). Additionally, as simple-form and html5 do not support conditionally required fields we shall not supply an option for that. Local file upload is marked as default for the radio-button mode
Currently an implementation of .retrieve, which will perform the fetching of the remote file, is still missing.
.original_filename only works for UploadFiles not for any other Tempfile (of course, as Tempfiles do not have an origin). So we'll need to refer to the iri instead. We'll just take the part after the last slash '/' as the filename.
We should make this job asynchronous later on. However for now synchronous is good enough.
The controllers only action (create/POST) will retrieve the filetype behind a given iri.
Provide filename suggestions if a filename has not been set and the url-filename does not contain a fileextension. Also provide suggestions if the filename that was set matches the one provided by a previous suggestion.
Conflicts: db/migrate/20141206163145_add_mappings_to_file_extension_mime_type_mappings.rb
as the remote-iri can contain a query-string, we will safely ignore the query-string part if it exists.
|
Mh i don't get the same issue. For me it suggests: |
0robustus1
force-pushed
the
28-remote_file_upload
branch
from
eee9475
to
2ed5c2f
Compare
|
When I wrote the comment, it said |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #28. Needs the current version of hets.