1171 add commit model #1173
Merged
1171 add commit model #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding or deleting a file we should create a corresponding commit object for the commit.
We should easily get all ontology_versions that were created due to a commit and all ontologies that were influenced by a commit.
This rake task will migrate the existing data to commit-objects and link ontology_versions appropriately. If we were however to remove the commit_oid field from ontology_versions we could only do so after this rake task has been run.
| @@ -128,6 +131,22 @@ def create_version(ontology, commit_oid, ontology_version_options) | |||
| version | |||
| end | |||
|
|
|||
| def commit_for!(commit_oid) | |||
There was a problem hiding this comment.
Metrics/MethodLength: Method has too many lines. [13/10]
There was a problem hiding this comment.
Can't really shorten it. Do you see a good way @eugenk?
There was a problem hiding this comment.
How about something like
def commit_for!(commit_oid)
instance = Commit.where(repository_id: self, commit_oid: commit_oid).
first_or_initialize
setup_commit_instance(instance) unless instance.persisted?
instance
end
def setup_commit_instance(instance)
commit = git.repo.lookup(instance.commit_oid)
data = commit.committer
instance.committer = "#{data[:name]} <#{data[:email]}>"
instance.commit_date = data[:time]
data = commit.author
instance.author = "#{data[:name]} <#{data[:email]}>"
instance.author_date = data[:time]
instance.save!
end
| class Commit < ActiveRecord::Base | ||
| attr_accessible :commit_oid, :repository | ||
| attr_accessible :author, :author_date | ||
| attr_accessible :commit_date, :committer |
There was a problem hiding this comment.
attr_accessible :committer, :commit_date for consistency in the ordering with the author-line.
0robustus1
force-pushed
the
1171-add_commit_model
branch
from
7830709
to
60797cb
Compare
0robustus1
force-pushed
the
1171-add_commit_model
branch
from
60797cb
to
39aff35
Compare
Different repositories could contain commits with the same SHA, so we'll need to filter for the repository.
0robustus1
force-pushed
the
1171-add_commit_model
branch
from
39aff35
to
bd52790
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #1171, which again should help with the completion of #1154.