1190 restructure migrations #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`20140915123503_move_to_has_and_belongs_to_many_for_ontologies_tasks` has been split into two files: `20140915123503_move_to_has_and_belongs_to_many_for_ontologies_tasks`, `20140915123504_move_to_has_and_belongs_to_many_for_ontologies_tasks_end` because its data migration needs to be executed between two schema migrations.
| @@ -0,0 +1,871 @@ | |||
| class InitSchema < ActiveRecord::Migration | |||
There was a problem hiding this comment.
Metrics/ClassLength: Class definition is too long. [732/100]
|
Sorry Hound, I ignore your comments on the 20140615175553_init_schema.rb because that file is mostly generated. |
eugenk
force-pushed
the
1190-restructure_migrations
branch
from
e5fcb16
to
b4f37eb
Compare
|
test this please |
| raise 'Can not revert initial migration' | ||
| end | ||
|
|
||
| def up |
There was a problem hiding this comment.
Assignment Branch Condition size for up is too high. [576/15]
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shall fix #1190.
As for this pull request, the data migrations can be executed with
rake data:migrate. This is a synchronous job. It can be executed asynchronously in two ways:nohup rake data:migrate &. Then the job continues its work even if the ssh connection is closed. Its output is written into a file callednohup.out.rake data:migrate:asyncwhich creates a Sidekiq job that runsrake data:migrate. Interestingly, on my machine, the job is not added to thedefaultqueue, but to the queue with the empty name and stay "Enqueued". I can't explain why this happens. Your ideas are welcome :)For future coding: Other than schema migrations, data migrations are supposed to be changed whenever the code they depend on changes.