1061 handle hets api errors #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| class ExecutionError < HetsError | ||
| attr_reader :abort_execution | ||
|
|
||
| def initialize(msg=nil, abort_execution: false) |
There was a problem hiding this comment.
Style/SpaceAroundEqualsInParameterDefault: Surrounding space missing in default value assignment.
0robustus1
force-pushed
the
1061-handle_hets_api_errors
branch
2 times, most recently
from
858fdbe
to
12da985
Compare
This should allow custom error handling for all types of errors that are not handled by the GetCaller itself.
Descendants should/must provide an implementation of the perform method, which shall return `false` if error handling was not possible.
In order to function correctly an error handler needs the instance of the caller (GetCaller for example). As the error handler however was supplied when creating the caller this would create an impossible paradox. So we'll use a public-setter for now.
This way the method can determine itself whether error_handling was successful and call the block if appropriate.
We need the improved error-handling of hets for clif ontologies in the API.
When we access the path we will get a version that still contains percent-escapes, we'll need to unescape them to do the iri-check.
0robustus1
force-pushed
the
1061-handle_hets_api_errors
branch
from
858fdbe
to
4a096c9
Compare
|
👍 |
0robustus1
added a commit
that referenced
this pull request
Feb 23, 2015
1061 handle hets api errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shall partially fix #1061. It provides basic error handling in which the user will actually get the
hets-error message where possible. It however probably requires improvement, which i will do in a later pull-request. But seeing as this seems to be an important issue, we should still review and merge this pull-request.