1211 fix ref locids for subdirectories #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removes duplicate implementation of current_version, as there is already a (better) one in versions.rb.
|
|
||
| before do | ||
| ontology_version | ||
| allow_any_instance_of(Hets::ParseCaller).to receive(:call) do |iri, *args| |
There was a problem hiding this comment.
Unused block argument - args. If it's necessary, use _ or _args as an argument name to indicate that it won't be used.
Line is too long. [82/80]
0robustus1
force-pushed
the
1211-fix_ref_locids_for_subdirectories
branch
from
0e89c99
to
22c6455
Compare
|
|
||
| before do | ||
| ontology_version | ||
| allow_any_instance_of(Hets::ParseCaller).to receive(:call) do |iri, *_args| |
Apparently updating the locid column does not work if the migration is executed on the same run as the creation of the locid column (that at least applies for my machine). So we'll use update_column.
| portion = e.name.split('#', 2).last | ||
| portion.end_with?('>') ? portion[0..-2] : portion | ||
| portion = e.name.end_with?('>') ? e.name[0..-2] : e.name | ||
| portion = portion.split('#', 2).last |
There was a problem hiding this comment.
Useless assignment to variable - portion.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
Travis fails because of spechub/Hets#1455. This can be merged 👍 |
0robustus1
added a commit
that referenced
this pull request
Feb 20, 2015
…ctories 1211 fix ref locids for subdirectories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shall fix #1211. Additionally provides the migration to update existing data with locids.