1152 replace capybara webkit by phantomjs #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,6 +6,8 @@ | |||
| require File.expand_path("../../../spec/shared_helper", __FILE__) | |||
|
|
|||
| require 'cucumber/rails' | |||
| require 'capybara/poltergeist' | |||
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
I'm assuming that this fails on jenkins because phantom.js isn't yet installed on the machine. |
eugenk
force-pushed
the
1152-replace_capybara_webkit_by_phantomjs
branch
from
b5f5d65
to
4427eb4
Compare
eugenk
force-pushed
the
1152-replace_capybara_webkit_by_phantomjs
branch
from
4427eb4
to
d69b803
Compare
|
test this please |
eugenk
added a commit
that referenced
this pull request
Mar 10, 2015
…_phantomjs 1152 replace capybara webkit by phantomjs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shall fix #1152. This branch is based on the one of #1236 because I wanted to document the external dependencies directly in the new development setup pages.