1292 add api key #1293
Merged
1292 add api key #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why? One could want to have different API keys for different applications. |
|
API-Keys are user-based not application-based. Technically there is no reason to not allow multiple API-Keys, but this assumes that users can handle their keys correctly. |
|
The code looks good. I still need to play around with the new feature. Now I don't have time, though. Maybe later today or tomorrow in the morning. |
| private | ||
| def initialize_key | ||
| generate_key! unless key | ||
| set_status! unless status |
Also renames set_status! method to set_valid! and uses the valid-scope in its own methods.
0robustus1
force-pushed
the
1292-add_api_key
branch
from
e672cd8
to
936099b
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shall close #1292.
Adds API-Keys to the application. Every user can create API-Keys. Only one per user will be valid at any given time. Currently the invalid ones will also be stored indefinitely - we might want to change this later on.
Also adds 'current_user' handling based on the api-key for the API-Controller. Tests for this part will however have to wait until the first feature is implemented, that actually needs authentication (which will probably be #1156).