1280 hets error handling for proving #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the `dg` command, hets outputs: "*** Error: <message>" and in the `prove` command, hets outputs: "*** Error: <message>" So the `\Z` in the regexp is removed and the error message includes the first line without the prefix "*** Error:"
The cause is set implicitly in the rescue block.
|
|
||
| it "ontology_version's last_error contains the error message" do | ||
| expect(ontology_version.reload.last_error).to include(error_message) | ||
| end | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
Lines 104-155 and 271-322 of this file are identical. Moreover, lines 48-187 and 215-355 are similar. Could this be factored out?
There was a problem hiding this comment.
For the same reason as in #1298 I decided to have some code duplication in the specs. Again, this operates once on ontology_version and once on theorem. I can create a context for the identical parts of theorem and ontology_version, if you want me to do it.
There was a problem hiding this comment.
I think this is a general question about the policy in Ontohub. I let you decide.
|
👍 |
eugenk
added a commit
that referenced
this pull request
Apr 2, 2015
…oving 1280 hets error handling for proving
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shall fix #1280. Hets errors are recognized and the states are updated properly.
This only handles errors in the backend. Views for errors and states are part of #1283.