Report coverage only on default task #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugenk
force-pushed
the
report_coverage_only_on_default_task
branch
from
ae29ca5
to
0d14646
Compare
| @@ -34,6 +34,7 @@ def gemsets | |||
| end | |||
|
|
|||
| def use_simplecov | |||
| return unless ENV['COVERAGE'] | |||
There was a problem hiding this comment.
Shouldn't the caller of use_simplecov decide whether simplecov is supposed to be used? If not, we should rename the method.
|
Please rebase staging. |
A simple run of `rspec spec/something_spec.rb:123` spends a lot of time on generating the coverage report. This disables the coverage report by default, except for the default rake task.
eugenk
force-pushed
the
report_coverage_only_on_default_task
branch
from
0d14646
to
e937ecc
Compare
|
Done. |
|
👍 |
eugenk
added a commit
that referenced
this pull request
May 6, 2015
…_task Report coverage only on default task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple run of
rspec spec/something_spec.rb:123spends a lot of time ongenerating the coverage report.
This disables the coverage report, except for the default rake task.
If a coverage report is desired even for other tasks, just set the environment variable
COVERAGE, e.g.: