Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1135 allow selection of axioms #1326

Merged
merged 21 commits into from
May 26, 2015
Merged

1135 allow selection of axioms #1326

merged 21 commits into from
May 26, 2015

Conversation

eugenk
Copy link
Member

@eugenk eugenk commented Apr 21, 2015

This shall fix #1135. It adds the manual selection of axioms for proving.

The branch of this pull request is based on:

The first commit of this branch is:
Allow to select axioms. 083053b

@tillmo
Copy link
Member

tillmo commented May 19, 2015

Currently, I cannot prove theorems in this branch.
I checkout the branch, merge in #1342, do a rake db:migrate:clean and rake db:seed, and then try a proof. I get:

2015-05-19T19:49:25.974Z 10717 TID-12tqw0 ERROR: Actor crashed!
NoMethodError: undefined method `proof_attempts' for nil:NilClass
        /home/till/web2.0/ontohub/lib/hets/prove/prove_evaluation_helper.rb:8:in `
fill_proof_attempt_from_hash'
        /home/till/web2.0/ontohub/lib/hets/prove/prove_evaluator.rb:79:in `goal_en
d'
        /home/till/web2.0/ontohub/lib/hets/base_evaluator.rb:54:in `block in proce
ss'
        /home/till/web2.0/ontohub/lib/hets/base_evaluator.rb:53:in `each'
        /home/till/web2.0/ontohub/lib/hets/base_evaluator.rb:53:in `process'
        /home/till/web2.0/ontohub/lib/hets/json_parser.rb:37:in `call_back'
        /home/till/web2.0/ontohub/lib/hets/prove/parser.rb:34:in `select_callback'
        /home/till/web2.0/ontohub/lib/hets/json_parser.rb:71:in `object_end'
        /home/till/web2.0/ontohub/lib/hets/json_parser.rb:29:in `block in initiali
ze_parser_hooks'

@eugenk eugenk force-pushed the 1135-allow_selection_of_axioms branch from 7547d69 to cf00548 Compare May 20, 2015 08:03
@eugenk
Copy link
Member Author

eugenk commented May 20, 2015

I rebased staging after merging #1343 and that error doesn't seem to appear now.

@tillmo
Copy link
Member

tillmo commented May 24, 2015

👍 (modulo travis...)

@eugenk eugenk force-pushed the 1135-allow_selection_of_axioms branch from cf00548 to 1580204 Compare May 26, 2015 11:11
@eugenk
Copy link
Member Author

eugenk commented May 26, 2015

I rebased on #1324, where I added two commits. I assume it's still okay to merge this one as soon as #1324 gets merged.

@eugenk eugenk force-pushed the 1135-allow_selection_of_axioms branch from 1580204 to 6d6d389 Compare May 26, 2015 11:44
@eugenk eugenk force-pushed the 1135-allow_selection_of_axioms branch from 6d6d389 to d3db10c Compare May 26, 2015 12:27
eugenk added a commit that referenced this pull request May 26, 2015
@eugenk eugenk merged commit 9ed9be3 into staging May 26, 2015
@eugenk eugenk deleted the 1135-allow_selection_of_axioms branch May 26, 2015 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow selection of axioms
2 participants