-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1325 parse hets json snake case keys #1327
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugenk
force-pushed
the
1325-parse_hets_json_snake_case_keys
branch
from
April 27, 2015 19:29
0dc4433
to
7c281fe
Compare
Merged
This was referenced Apr 29, 2015
Later we will add an 'automated' and a 'default' flag to the provers list and then we only need to update the ALLOWED_KEYS.
eugenk
force-pushed
the
1325-parse_hets_json_snake_case_keys
branch
2 times, most recently
from
May 4, 2015 14:26
a612bf9
to
dc45593
Compare
eugenk
force-pushed
the
1325-parse_hets_json_snake_case_keys
branch
from
May 4, 2015 14:27
dc45593
to
b715248
Compare
I rebased on staging and added the last commit |
👍 |
eugenk
added a commit
that referenced
this pull request
May 5, 2015
…_keys 1325 parse hets json snake case keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shall fix #1325 and also use the new
display_name
of Hets' provers list.Hets now outputs JSON with snake case (instead of camel case) object keys. Our parsers need to be adjusted to this.
Because our CI services use the bleeding-edge version of Hets, they will always fail without the changes of this branch.