Refactor history spec #1331
Merged
Refactor history spec #1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugenk
force-pushed
the
refactor_history_spec
branch
from
37b0094
to
d703ed2
Compare
eugenk
force-pushed
the
refactor_history_spec
branch
from
d703ed2
to
22f3bad
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The history spec had poorly chosen
describeandcontextdescriptions, which are changed here.Also the nesting of the contexts was bad because there were two
describeblocks. I changed them into twocontexts inside of onedescribe.The diff is only this huge because the indentation changed.