Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use less verbose test output formatter #1333

Merged
merged 5 commits into from
May 27, 2015

Conversation

eugenk
Copy link
Member

@eugenk eugenk commented Apr 25, 2015

The quite verbose formatter annoyed me a little because it printed way more information than we needed. This pull request adds formatters that combine the strengths of the very verbose formatters documentation (for rspec) and pretty (for cucumber) and of the too little printing formatter progress.

Those are only active by default on development machines. I made sure that the verbose formatters are used on travis and jenkins.

rspec

screen shot 2015-04-25 at 11 12 33

cucumber

screen shot 2015-04-25 at 11 13 34

@eugenk eugenk force-pushed the use_less_verbose_test_output_formatter branch from 55c4af8 to b1a2b1a Compare May 5, 2015 10:10
@eugenk eugenk force-pushed the use_less_verbose_test_output_formatter branch from b1a2b1a to f4e9950 Compare May 20, 2015 08:06
@0robustus1
Copy link
Contributor

Mhm, per default i would only activate the middleground for rspec (where it is really necessary). For cucumber i think that the verbose output is actually necessary/extremely useful.

@eugenk
Copy link
Member Author

eugenk commented May 20, 2015

I think verbose output in cucumber is only useful when something fails. Otherwise it's just some green text that you don't read anyway. At least I don't.

In my opinion it clutters the console. We don't have that many cucumber features at this point, but when it gets more, I think we really want to shorten the output.

@0robustus1
Copy link
Contributor

Yeah, but you do not get the full output for a failing test, and i think for cucumber (with their step-system) it is important to see them all.

@0robustus1
Copy link
Contributor

@ebolloff want to be the tie-breaker?

@eugenk
Copy link
Member Author

eugenk commented May 20, 2015

Yes, then I think I should change the formatter to print the full output of a failing test.

@0robustus1
Copy link
Contributor

If that would be possible, it would probably be the optimal case.

@eugenk eugenk force-pushed the use_less_verbose_test_output_formatter branch from 3b52fdd to 6be3cde Compare May 27, 2015 06:38
@eugenk
Copy link
Member Author

eugenk commented May 27, 2015

How about now? a44c794 "Print failure details after the features." should add the details.

@0robustus1
Copy link
Contributor

👍

eugenk added a commit that referenced this pull request May 27, 2015
…rmatter

Use less verbose test output formatter
@eugenk eugenk merged commit d674635 into staging May 27, 2015
@eugenk eugenk deleted the use_less_verbose_test_output_formatter branch May 27, 2015 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants