Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Bundle is not complete for deployment #1367

Merged
merged 3 commits into from
Jun 5, 2015

Conversation

eugenk
Copy link
Member

@eugenk eugenk commented Jun 4, 2015

Shall fix #1366.

While deploying, rake task files are loaded and they use VCR.
@eugenk
Copy link
Member Author

eugenk commented Jun 4, 2015

I cherry-picked this commit to develop.ontohub.org (with conflict solving) and it works there.

@0robustus1
Copy link
Contributor

Could we document this somewhere? (What files/fixtures are used and why)

@eugenk
Copy link
Member Author

eugenk commented Jun 5, 2015

You mean to extend doc/most_important_gems.md?

@0robustus1
Copy link
Contributor

That would be the place to add vcr and webmock, but i also want to document (maybe in productive deployment documentation, why we need the files and what they are used for, and when they are subject to change).

@eugenk
Copy link
Member Author

eugenk commented Jun 5, 2015

Done with cb99870

@0robustus1
Copy link
Contributor

After green tests: 👍

eugenk added a commit that referenced this pull request Jun 5, 2015
…_deployment

Fix: Bundle is not complete for deployment
@eugenk eugenk merged commit a1444fe into staging Jun 5, 2015
@eugenk eugenk deleted the 1366-bundle_is_not_complete_for_deployment branch June 5, 2015 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bundle is not complete for deployment
2 participants