Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix axiom selection #1387

Merged
merged 3 commits into from
Jun 26, 2015
Merged

Fix axiom selection #1387

merged 3 commits into from
Jun 26, 2015

Conversation

eugenk
Copy link
Member

@eugenk eugenk commented Jun 26, 2015

This fixes a bug that made the axiom selection a no-op.

There was a wrong "@" (there is no instance variable @axiom_ids).
Only non-imported axioms were considered, but all need to be considered.
@eugenk eugenk added this to the Reasoning milestone Jun 26, 2015
end
end
end

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about using match_array here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I didn't know that matcher. It's fixed in e688e7b

@tillmo
Copy link
Member

tillmo commented Jun 26, 2015

👍

eugenk added a commit that referenced this pull request Jun 26, 2015
@eugenk eugenk merged commit 01c52ae into staging Jun 26, 2015
@eugenk eugenk deleted the fix_axiom_selection branch June 26, 2015 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants