-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify GIT_HOME environment variable for rebuild script #1426
Conversation
There are some things which are broken on my machine right now, thats why I got a red test (which is also red on other branches). Maybe @SGraef wants to check it, too? On my side 👍 |
I added another fix because the first commit didn't really use the absolute file path. |
Just a question from my side: Why do we need a specific Environment Variable to be set (mandatory)? Usually those are only used to provide options and it should work with reasonable defaults without specifiying an Env-Var. |
There's no place in the ontohub code/settings files any more where we have this path. I could've hard coded the default default directly into the rake task. I didn't do so because many rake tasks have mandatory environment variable settings and I didn't want production systems to have a default. |
Alright. Even though you have already documented the variable in the productive-deployment documentation i would suggest to also document it in development related documentation, just so we can easily know about it in a few months/years time. |
Right. Done with d492d49 |
👍 |
Specify GIT_HOME environment variable for rebuild script
The GIT_HOME environment variable was not set in the rebuild script.
This adds a default value.