Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify GIT_HOME environment variable for rebuild script #1426

Merged
merged 3 commits into from
Aug 5, 2015

Conversation

eugenk
Copy link
Member

@eugenk eugenk commented Jul 16, 2015

The GIT_HOME environment variable was not set in the rebuild script.
This adds a default value.

@ebolloff
Copy link
Member

There are some things which are broken on my machine right now, thats why I got a red test (which is also red on other branches). Maybe @SGraef wants to check it, too? On my side 👍

@eugenk
Copy link
Member Author

eugenk commented Jul 17, 2015

I added another fix because the first commit didn't really use the absolute file path.

@0robustus1
Copy link
Contributor

Just a question from my side: Why do we need a specific Environment Variable to be set (mandatory)? Usually those are only used to provide options and it should work with reasonable defaults without specifiying an Env-Var.

@eugenk
Copy link
Member Author

eugenk commented Jul 18, 2015

There's no place in the ontohub code/settings files any more where we have this path. I could've hard coded the default default directly into the rake task. I didn't do so because many rake tasks have mandatory environment variable settings and I didn't want production systems to have a default.

@0robustus1
Copy link
Contributor

Alright. Even though you have already documented the variable in the productive-deployment documentation i would suggest to also document it in development related documentation, just so we can easily know about it in a few months/years time.

@eugenk
Copy link
Member Author

eugenk commented Jul 19, 2015

Right. Done with d492d49

@SGraef
Copy link
Member

SGraef commented Aug 5, 2015

👍

eugenk added a commit that referenced this pull request Aug 5, 2015
Specify GIT_HOME environment variable for rebuild script
@eugenk eugenk merged commit 171c4fd into staging Aug 5, 2015
@eugenk eugenk deleted the fix_git_home branch August 5, 2015 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants