1411 restructure proving pipeline #1427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need it in several places now.
There will be more subclasses of AxiomSelection each with different attributes. To avoid creating many NULL values in the database, we use multiple table inheritance with the gem 'acts_as_relation'. This gem mimicks actual class inheritance of ruby with the method `acts_as`. The migration changes the has_and_belongs_to_many association between Axioms and ProofAttemptConfigurations to be between Axioms and AxiomSelections.
When the ProofAttemptCofiguration only has one proof_attempt, there can only be a single goal. This can be retrieved through the proof_attempt.
This allows us to run many proofs in parallel and simplifies the Proof class.
Now that there is only one ProofAttemptConfiguration per ProofAttempt, we can remove this association. The numbering can be dropped as well. Next, the loc/id and routes must be adjusted because it is now associated primarily with the ProofAttempt.
This is not needed anymore because we have a one-to-one relation between ProofAttemptConfiguration and ProofAttempt.
|
I got an error for |
|
Those two problems should be solved now. |
|
👍 |
eugenk
added a commit
that referenced
this pull request
Jul 20, 2015
1411 restructure proving pipeline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shall fix #1411. The next pull request will change some of this again, but those changes will be very small.
This pull request is based on the branch of #1391 (1134-create_basis_for_many_axiom_selection_methods) instead of staging.
The first new commit in this branch is:
c79944b Add ProofExecution[Worker].