Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squash migrations #1435

Merged
merged 2 commits into from
Aug 10, 2015
Merged

Squash migrations #1435

merged 2 commits into from
Aug 10, 2015

Conversation

eugenk
Copy link
Member

@eugenk eugenk commented Jul 28, 2015

We have gathered a lot of migrations in the past year. This pull request squashes all migrations into one big schema migration and removes the data migrations since they have been all been applied to ontohub.org.

In my opinion, this is needed because some schema migrations made changes back and forth and this new squashed migration shows the clean state. Also, this speeds up rebuilding the database on our development machines a little bit.

I used the gem squasher to do this. After executing it, I re-added the SQL functions and some data at the bottom of the init_schema migration (copied over from the previous init_schema and added omn to the ontology file extensions).

@SGraef
Copy link
Member

SGraef commented Aug 5, 2015

👍

@eugenk
Copy link
Member Author

eugenk commented Aug 5, 2015

I rebased on staging and there were conflicts:

UD db/migrate/20150217121518_create_loc_ids_for_existing_ontologies.rb
UD db/migrate/20150311125212_make_sentences_to_axioms.rb
UD db/data/20140823134219_set_count_fields_correctly.rb
UD db/data/20141102203932_update_display_text_for_obo_sentences.rb

Those updates only added the original scope on Sentence/sentences calls or removed an unscoped. This is irrelevant for this squashing. However, I want to wait for another sign off because of the conflicts.

@SGraef
Copy link
Member

SGraef commented Aug 10, 2015

👍

eugenk added a commit that referenced this pull request Aug 10, 2015
@eugenk eugenk merged commit 4ce3f1a into staging Aug 10, 2015
@eugenk eugenk deleted the squash_migrations branch August 10, 2015 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants