Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1443 fix evaluation state on theorems #1444

Merged
merged 6 commits into from
Aug 11, 2015

Conversation

eugenk
Copy link
Member

@eugenk eugenk commented Aug 6, 2015

This shall fix #1443.

@tillmo
Copy link
Member

tillmo commented Aug 10, 2015

If there are multiple proof attempts, their statuses should be combined by taking maximum in the following total order: failed - no_result - pending - processing - fetching - done, where no_result is a new status that should be set in case of a timeout. The presence of failed proof attempts should be displayed in a global error menu.

@eugenk eugenk force-pushed the 1443-fix_evaluation_state_on_theorems branch from fc078c1 to 7e6b3bb Compare August 10, 2015 13:52
@eugenk eugenk force-pushed the 1443-fix_evaluation_state_on_theorems branch from 7e6b3bb to e8d619c Compare August 10, 2015 13:52
@eugenk eugenk force-pushed the 1443-fix_evaluation_state_on_theorems branch from f1a0097 to bb0972f Compare August 10, 2015 14:46
@eugenk
Copy link
Member Author

eugenk commented Aug 10, 2015

I added the state selection based on the total order in bb0972f.

Now they are more structured and complete.
There are no examples for the fetching state because that one is
irrelevant for ProofAttempts.
@tillmo
Copy link
Member

tillmo commented Aug 10, 2015

I get an error when running the tests:

rake db:migrate:clean
[...]
rake db:seed
[...]
rake
[...]
/home/till/.rvm/gems/ruby-2.1.5@ontohub/gems/activerecord-3.2.22/lib/active_record/connection_adapters/postgresql_adapter.rb:1163:in `async_exec': PG::UndefinedTable: ERROR:  relation "axiom_selections" does not exist (ActiveRecord::StatementInvalid)
LINE 5:              WHERE a.attrelid = '"axiom_selections"'::regcla...
                                        ^
:             SELECT a.attname, format_type(a.atttypid, a.atttypmod),
                     pg_get_expr(d.adbin, d.adrelid), a.attnotnull, a.atttypid, a.atttypmod
              FROM pg_attribute a LEFT JOIN pg_attrdef d
                ON a.attrelid = d.adrelid AND a.attnum = d.adnum
             WHERE a.attrelid = '"axiom_selections"'::regclass
               AND a.attnum > 0 AND NOT a.attisdropped
             ORDER BY a.attnum
    from /home/till/.rvm/gems/ruby-2.1.5@ontohub/gems/activerecord-3.2.22/lib/active_record/connection_adapters/postgresql_adapter.rb:1163:in `exec_no_cache'

@eugenk
Copy link
Member Author

eugenk commented Aug 10, 2015

Please try RAILS_ENV=test rake db:migrate:reset. I occasionally get the same error, but don't know where it comes from. Resetting the test database always fixes it.

@tillmo
Copy link
Member

tillmo commented Aug 11, 2015

👍

eugenk added a commit that referenced this pull request Aug 11, 2015
…eorems

1443 fix evaluation state on theorems
@eugenk eugenk merged commit b0b3484 into staging Aug 11, 2015
@eugenk eugenk deleted the 1443-fix_evaluation_state_on_theorems branch August 11, 2015 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix evaluation state on theorems
2 participants