Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix proving timeout #1456

Merged
merged 2 commits into from
Aug 24, 2015
Merged

Fix proving timeout #1456

merged 2 commits into from
Aug 24, 2015

Conversation

eugenk
Copy link
Member

@eugenk eugenk commented Aug 18, 2015

This fixes two little issues:

  1. Hets closes the connection after 60 seconds. We shouldn't allow timeouts this long. This is supposed to be reverted as soon as we can have an open connection for as long as the job takes.
  2. Since the proving pipeline refactoring the timeout is no longer split across the proof obligations. The hint needed to be adjusted accordingly.

@eugenk
Only allow timeouts less than 60 seconds.
3ad9bc0 
Hets closes the HTTP connections after 60 seconds, so we can't allow
timeouts that are greater than or equal to 60 seconds.
@eugenk
Fix timeout hint.
3692fec
@eugenk eugenk added this to the Reasoning milestone Aug 18, 2015
@tillmo
Copy link
Member

tillmo commented Aug 22, 2015

👍

eugenk added a commit that referenced this pull request Aug 24, 2015
@eugenk
Merge pull request #1456 from ontohub/fix_proving_timeout
93f183f 
Fix proving timeout
@eugenk eugenk merged commit 93f183f into staging Aug 24, 2015
@eugenk eugenk deleted the fix_proving_timeout branch August 24, 2015 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tillmo tillmo

Labels
None yet
Projects
None yet
Milestone
Reasoning
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eugenk @tillmo